Remove last config package and move to root level package linting#4109
Open
Remove last config package and move to root level package linting#4109
Conversation
Saadnajmi
reviewed
May 11, 2026
Comment on lines
+1
to
+12
| const { defineConfig } = require('@yarnpkg/types'); | ||
| const { constrain } = require('./scripts/src/index.ts'); | ||
|
|
||
| module.exports = defineConfig({ | ||
| constraints: async ({ Yarn }) => { | ||
| for (const workspace of Yarn.workspaces()) { | ||
| if (workspace.cwd !== '.') { | ||
| constrain(workspace); | ||
| } | ||
| } | ||
| }, | ||
| }); |
Collaborator
There was a problem hiding this comment.
Can we add a comment to make it a little more obvious that instead of implementing constraints dirctly, we are using our helper package?
Saadnajmi
reviewed
May 11, 2026
Comment on lines
+41
to
+47
| const command = lintCommands[cmdName][key]; | ||
| if (command) { | ||
| if (fix) { | ||
| if (!(await execCommand(cmdName, command))) { | ||
| return 1; | ||
| } | ||
| } else { |
Collaborator
There was a problem hiding this comment.
It feels like this could be handled by Lage?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
lint-repo/lint-repo --fixcommand at the root which runs through the various repo wide linting operations. This takes ~4 seconds on my machine instead of the > 1 minute that the lint-package routine used to take.lintPackage is still present as some of the code in there will need to be moved over, but I will likely not keep all of it so that will be done later.
Verification
Automation